New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support backup of mariadb using mariabackup #967
Conversation
2611fd9
to
9b8462c
Compare
49494ad
to
9a2bbf0
Compare
158d8c6
to
7a67f06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's little code changes that need to be addressed and also a few files that shouldn't be there.
core/src/plugins/filed/python/mariabackup/BareosFdPluginMariabackup.py
Outdated
Show resolved
Hide resolved
core/src/plugins/filed/python/mariabackup/BareosFdPluginMariabackup.py
Outdated
Show resolved
Hide resolved
core/src/plugins/filed/python/mariabackup/BareosFdPluginMariabackup.py
Outdated
Show resolved
Hide resolved
core/src/plugins/filed/python/mariabackup/BareosFdPluginMariabackup.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adressed all comments and should be OK now.
41158a8
to
0c67337
Compare
e62d35f
to
bbd4b95
Compare
- Update test for mariadb and percona plugin to backup and recover a full database with content verification. - General overhaul and refactoring of testrunners. - The mariabackup and percona tests can and need to be run as unprivileged user. - Package the mariabackup plugin for deb and rpm. - Detect required binaries both for mariadb and for mysql/percona. - Binary specification can be don via commandline which will skip the detection. This is currently required to run both mysql/percona and mariabackup tests as the binary names are identical.
2ecb2d3
to
f5b039f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is now reviewed and ok.
Need to find a committer.
Thank you for contributing to the Bareos Project!
MariaDB has the tool "mariabackup" which offers the same functionality as percona xtrabackup.
This PR introduces a new filedaemon plugin that can backup mariadb servers via mariabackup.
The plugin is based on the percona-xtrabackup plugin.
Also, this PR adds a systemtests that tests the full backup-restore cycle for mariadb and also adds
this functionality to the percona xtrabackup plugin system tests.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
Required documentation changes are present and part of the PRDocumentation will be a separate PR
bareos-check-sources --since-merge
does not report any problemsgit status
should not report modifications in the source tree after building and testingTests