Load Jabber module lazily #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation of lazily loading the Jabber module.
Impl is still loaded at startup, but we're almost there.
Brings our startup RSS down from about 45MB to 32MB. Fixes #213.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a ton of modules, and they currently cost us quite a bit in both startup and memory. (Go stick a return in
BarnOwl::ModuleLoader::load_alland see what happens. It's pretty shocking.) It would be probably good to load the modules on-demand in some way. Exactly how, I don't know. Here's an idea for just doing it within each module. We could also do it at the module-loading layer instead. Breaking everyone's.owl/startupif we require you to explicitlyload-module Jabberbeforejabberlogineven exists may or may not be okay, I dunno. There's also just additional UI complexity if you require users to explicitly load the module. If we load them on demand, we're going to have to change all the modules anyway to export their commands another way or something. On the other hand, doing it at the module-loading layer is probably less logic we have to duplicate.My completely unscientific testing suggests the next biggest offenders are the Facebook and Twitter modules. I believe they both have some autologin feature, which might also be affected by something like this? IRC is also noticeable, but not as huge.