Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store content for cite #31

Open
jamietanna opened this issue Nov 18, 2021 · 3 comments
Open

Don't store content for cite #31

jamietanna opened this issue Nov 18, 2021 · 3 comments

Comments

@jamietanna
Copy link
Contributor

To avoid unnecessary storage overhead (in the case of long posts) as well as potential copyright claims we should remove the content for a context.

That being said, we would want this for a repost so maybe it needs more nuance?

@barryf
Copy link
Owner

barryf commented Nov 18, 2021

On my website I display a truncated version of the content for a few different types. I did consider the copyright aspect so Vibrancy doesn't store the content on GitHub, just in the contexts table. There's no size limit which could be worth looking at.

@jamietanna
Copy link
Contributor Author

That's fair 👍 Yeah maybe taking the first ~1000 characters should be plenty?

@barryf
Copy link
Owner

barryf commented Nov 18, 2021

That should work. I truncate after the first 30 words: https://github.com/barryf/barryfrost/blob/master/src/http/get-catchall/helpers.js#L35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants