Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Micropub CRUD on contacts #30

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamietanna
Copy link
Contributor

@jamietanna jamietanna commented Nov 16, 2021

WIP:

  • validation for required-properties doesn't seem to be working - looks like there's nothing automagic (as I was expecting)
  • commit history needs to split, as there's a mix of things being changed, here
  • does it make sense to use channels in this way?
  • does it make sense to have the logic for checking the post-type like so?
  • remove console.logs
  • don't trigger syndication

Notes:

  • all the CRUD actions seem to work!

Closes #22

@@ -16,6 +26,13 @@ function deriveUrl (post) {
slug = post.properties['mp-slug'][0]
}
}

if (post.channel === 'contacts') {
return `contacts/${post.properties.nickname[0]}`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test input will need to change as we've not done it quite this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Micropub actions for contacts
1 participant