Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good news @barryvdh ! it looks like all we need to do, to provide Laravel 8 support, is to allow the installation 🥳 I have tested the most important features, and they work just fine:
If anybody else wants to test this, or upgrade to Laravel 8 before this PR gets merged (or an alternative one), please:
composer.json
's repositories section:composer require barryvdh/laravel-elfinder:"dev-l8-compatibility as 0.4.99"
Note that I have no intention of keeping that fork. Immediately after the official repo provides Laravel 8 support, I'll delete it. At that point you should undo the changes above, run
composer update
and it'll work just fine.