Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Laravel 8 #285

Merged
merged 1 commit into from
Sep 11, 2020
Merged

add support for Laravel 8 #285

merged 1 commit into from
Sep 11, 2020

Conversation

tabacitu
Copy link
Sponsor Contributor

@tabacitu tabacitu commented Sep 8, 2020

Good news @barryvdh ! it looks like all we need to do, to provide Laravel 8 support, is to allow the installation 🥳 I have tested the most important features, and they work just fine:

2020-09-08 10 07 20


If anybody else wants to test this, or upgrade to Laravel 8 before this PR gets merged (or an alternative one), please:

  • add my fork to your composer.json's repositories section:
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/tabacitu/laravel-elfinder"
        }
    ],
  • run composer require barryvdh/laravel-elfinder:"dev-l8-compatibility as 0.4.99"

Note that I have no intention of keeping that fork. Immediately after the official repo provides Laravel 8 support, I'll delete it. At that point you should undo the changes above, run composer update and it'll work just fine.

@nguyentranchung
Copy link

php version should >= 7.3

@tabacitu
Copy link
Sponsor Contributor Author

tabacitu commented Sep 10, 2020

Indeed, Laravel 8 does require PHP 7.3+, a requirement which should be imposed just fine thanks to the fact that illuminate/support is a dependency and has it - https://github.com/illuminate/support/blob/master/composer.json

This PR intentionally does not force a PHP version bump, it adds L8 support as a non-breaking change.

If someone installs this package on

  • Laravel 7, then the illuminate/support version will require php 7.2.5+
  • Laravel 8, then the illuminate/support version will require php 7.3+

No need to bump the required PHP version here too, in my opinion.

@tabacitu tabacitu mentioned this pull request Sep 11, 2020
@barryvdh barryvdh merged commit d3bc80d into barryvdh:master Sep 11, 2020
@barryvdh
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants