Support certificate chain #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people get this error (when they try to get a valid certificate from the keystore):
Following this issue, the
Length of buffer does not match length of ASN.1 sequenceis caused when a certificate chain is used instead of only the server certificate.And indeed in one of the cases that I examined, a certificate chain was being used:
So instead of sending a single certificate in the output message, I need to split the pem file based on newlines. Then I can send the certificate chain as an array in the output message:
The R3 certificate is the intermediate certificate chain from Letsencrypt, as you can see here.