Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log why entities are privatized #1116

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

bartfeenstra
Copy link
Owner

This fixes #686

@bartfeenstra bartfeenstra added the enhancement New feature or request label Dec 28, 2023
@bartfeenstra bartfeenstra added this to the 0.3.0 milestone Dec 28, 2023
Copy link

Uploaded Betty for commit cd4bd5f. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (fda0a3b) 92.67% compared to head (7d175dc) 92.51%.

Files Patch % Lines
betty/privatizer.py 82.35% 3 Missing ⚠️
betty/model/ancestry.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x    #1116      +/-   ##
==========================================
- Coverage   92.67%   92.51%   -0.17%     
==========================================
  Files          74       74              
  Lines        8468     8473       +5     
==========================================
- Hits         7848     7839       -9     
- Misses        620      634      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Uploaded Betty for commit 7d175dc. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra merged commit a3fd5a7 into 0.3.x Dec 28, 2023
9 of 11 checks passed
@bartfeenstra bartfeenstra deleted the log-privatization-reasons branch December 28, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log why resources are privatized
1 participant