Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Code Formatting #128

Closed
aroemen opened this issue Aug 11, 2023 · 1 comment · Fixed by #150
Closed

[Feature] Code Formatting #128

aroemen opened this issue Aug 11, 2023 · 1 comment · Fixed by #150
Assignees
@barthofu
Labels
enhancement New feature or request
Milestone
v2.3

Comments

@aroemen
Copy link

aroemen commented Aug 11, 2023

Feature

Since this project heavily relies on discordx, it would be nice to implement coding standards and formatting similar to that project. Having prettier installed on this project would make contributing much easier and more uniform.
@aroemen aroemen added the enhancement New feature or request label Aug 11, 2023
@barthofu barthofu added this to the v2.3 milestone Aug 24, 2023
barthofu added a commit that referenced this issue Feb 8, 2024
@barthofu
feat(#128): antfu/eslint code formating
ab57cbc
barthofu added a commit that referenced this issue Feb 9, 2024
@barthofu
feat(#128): antfu/eslint code formating
54d2739
barthofu added a commit that referenced this issue Feb 9, 2024
@barthofu
style(#128): apply style fix lint
3e3cd1c 
+ change typescript aliases from `@<module>` to `@/<module>` (ex: `@services` -> `@/services` to distinguish them from external npm packages
barthofu added a commit that referenced this issue Feb 9, 2024
@barthofu
style(#128): apply style fix lint
63ca839 
+ change typescript aliases from `@<module>` to `@/<module>` (ex: `@services` -> `@/services` to distinguish them from external npm packages
@barthofu barthofu linked a pull request Feb 9, 2024 that will close this issue
128 feature code formatting #150
Merged
barthofu added a commit that referenced this issue Feb 9, 2024
@barthofu
feat(#128): antfu/eslint code formating
c1232b3
barthofu added a commit that referenced this issue Feb 9, 2024
@barthofu
style(#128): apply style fix lint
c8778b9 
+ change typescript aliases from `@<module>` to `@/<module>` (ex: `@services` -> `@/services` to distinguish them from external npm packages
@barthofu
Copy link
Owner

barthofu commented Feb 9, 2024 •
edited
Loading

@aroemen it has been added! we've defined a linter and a style formating using https://github.com/antfu/eslint-config as base.

will be shipped soon with the v2.3.

@barthofu barthofu closed this as completed Feb 9, 2024
@barthofu barthofu mentioned this issue Feb 12, 2024
Merged
barthofu added a commit that referenced this issue Feb 21, 2024
@barthofu
feat(#128): antfu/eslint code formating
5e82941
barthofu added a commit that referenced this issue Feb 21, 2024
@barthofu
style(#128): apply style fix lint
ba6efd6 
+ change typescript aliases from `@<module>` to `@/<module>` (ex: `@services` -> `@/services` to distinguish them from external npm packages
barthofu added a commit that referenced this issue Mar 4, 2024
@barthofu
feat(#128): antfu/eslint code formating
70f83fb
barthofu added a commit that referenced this issue Mar 4, 2024
@barthofu
style(#128): apply style fix lint
711f18c 
+ change typescript aliases from `@<module>` to `@/<module>` (ex: `@services` -> `@/services` to distinguish them from external npm packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barthofu barthofu

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.3
Development

Successfully merging a pull request may close this issue.

128 feature code formatting barthofu/tscord
2 participants
@aroemen @barthofu