Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in the Table of Contents in dark mode not visible #86

Closed
mermare opened this issue Aug 21, 2020 · 5 comments
Closed

Links in the Table of Contents in dark mode not visible #86

mermare opened this issue Aug 21, 2020 · 5 comments

Comments

@mermare
Copy link

mermare commented Aug 21, 2020

See screenshot. This is in iOS Books app and book version 1.3.
3C9D941A-040F-490A-81F9-7E34BA512558

*NOTE: This issue is fixed in the latest EPub version downloaded from GitHub and opened in Apple Books (iOS). v. 1.3 “Compiled: 2020-08-18 19-22-09”

@mermare
Copy link
Author

mermare commented Aug 21, 2020

Although... visited links in dark mode are still unreadable (dark on dark).

@hepabolu
Copy link
Contributor

I can confirm it's like that in iOS Books and in iPadOS Books, but it's ok in Mac Books.
However, there is not much I can do. It looks like the problem lies with the Books version.

I filed an issue in the converter project: asciidoctor/asciidoctor-epub3#366

@hepabolu
Copy link
Contributor

hepabolu commented Sep 12, 2020

After researching a bit more I think I found a clue. The links in the Table of Contents are marked as 'visited' right away. And the ePub styles the visited links a dark grey. That makes them hard to read in dark mode.

hepabolu added a commit that referenced this issue Sep 12, 2020
…d links in Night mode is reset to the original Apple Books color.
@hepabolu
Copy link
Contributor

It was actually the color of 'visited' links that made the links very hard to read in Night mode. The fix changes the visited color to the original Apple Books color when in Night mode. Caveat: there is no visible difference between visited and unvisited links in Night mode anymore.

@mermare
Copy link
Author

mermare commented Sep 12, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants