-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some geometries seems to be incomplete - few triangles missing #5
Comments
@bartmcleod tagging you as I am not sure if you have received any notification from Git. I have imported the same WRL to blender and it looks fine. |
@ram-sellamuthu Thanks for tagging me and thanks for your feedback, it is much appreciated. I will look into it. This might either be a serious issue, or just a few flipped triangles (triangles that are specified ccw while all others are cw, or the other way round). Please note that the VrmlParser library and threejs are not in sync, as my pull requests towards threejs are not merged yet (as far as I know). Keeping them in sync requires a separate pull request. You could verify the outcome based on my branch of threejs, if you like. |
@ram-sellamuthu Would it be possible for you to create a test case example that includes just one of the cylinders and presents the same behaviour? [Edit: nvm I can easily isolate a single indexed faceset from the file] |
@ram-sellamuthu Ok, so here it is: the last face defined in each IndexedFaceSet should also end with [Edit]The last set of indices does not need to be followed by |
Fixed in v0.7.4 |
Hi Bart,
Thanks a lot for your quick support and apologies for delayed response. I
was in a workshop since the day I raised this issue.
The newer version of VrmlParser works perfectly fine as expected.
Thanks,
Rajaram
…On Thu, Sep 6, 2018 at 1:55 AM Bart McLeod ***@***.***> wrote:
Closed #5 <#5>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ApAEnMWVCWsRHhqLLU3Jt_tLg9Ixsl10ks5uYDNGgaJpZM4WaSdm>
.
--
Thanks & Regards,
Rajaram Sellamuthu
Cell Phone: +91-91485-48808
|
Hi,
I was testing the same WRL file with Three.js and VrmlParser.js. I get slightly different visualizations. The WRL file has only one shape primarily IndexedFaceSet. I am herewith attaching the WRL file and also screenshots from two different browsers.
Requesting your inputs in this regard.
01_caster_assembly.zip
Thanks,
Rajaram
The text was updated successfully, but these errors were encountered: