Skip to content

Commit

Permalink
fix(golangci): linter settings
Browse files Browse the repository at this point in the history
  • Loading branch information
bartoszmajsak committed Sep 18, 2019
1 parent 789e873 commit c8624ff
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
14 changes: 14 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ linters-settings:
min-complexity: 12
dupl:
threshold: 128
funlen:
lines: 128
statements: 64
goconst:
min-len: 2
min-occurrences: 2
Expand Down Expand Up @@ -57,6 +60,17 @@ issues:
- path: pkg/k8s/
linters:
- dupl
- path: pkg/apis/
linters:
- stylecheck
# Exclude some linters from running on tests files.
- path: _test\.go
linters:
- gocyclo
- errcheck
- dupl
- gosec
- unused

service:
project-path: github.com/bartoszmajsak/github-changelog-generator
Expand Down
1 change: 0 additions & 1 deletion pkg/format/help_format.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ func RegisterTemplateFuncs() {
}
return "`" + flagType + "`"
})

}

const (
Expand Down
2 changes: 1 addition & 1 deletion test/ginkgo_custom_reporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
)

// RunSpecWithJUnitReporter calls custom ginkgo junit reporter
func RunSpecWithJUnitReporter(t *testing.T, description string) {
func RunSpecWithJUnitReporter(t *testing.T, description string) { //nolint[:unused]
junitReporter := reporters.NewJUnitReporter("ginkgo-test-results.xml")
ginkgo.RunSpecsWithDefaultAndCustomReporters(t, description, []ginkgo.Reporter{junitReporter})
}

0 comments on commit c8624ff

Please sign in to comment.