Merge branch 'shieldo-remove_document_check' into develop (PR solariu…

…mphp#296)
basdenooijer · Dec 22, 2014 · 36b27d7 · 36b27d7
2 parents a9d8a52 + 3d2e882
commit 36b27d7
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/library/Solarium/QueryType/Update/Query/Command/Add.php b/library/Solarium/QueryType/Update/Query/Command/Add.php
@@ -89,9 +89,12 @@ public function addDocument(DocumentInterface $document)
      */
     public function addDocuments($documents)
     {
-        foreach ($documents as $document) {
-            if (!($document instanceof DocumentInterface)) {
-                throw new RuntimeException('Documents must implement DocumentInterface.');
+        //only check documents for type if in an array (iterating a Traversable may do unnecessary work)
+        if (is_array($documents)) {
+            foreach ($documents as $document) {
+                if (!($document instanceof DocumentInterface)) {
+                    throw new RuntimeException('Documents must implement DocumentInterface.');
+                }
             }
         }