Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates removed for foundation module #67

Closed
soumak77 opened this issue Aug 24, 2016 · 1 comment
Closed

Templates removed for foundation module #67

soumak77 opened this issue Aug 24, 2016 · 1 comment

Comments

@soumak77
Copy link
Contributor

soumak77 commented Aug 24, 2016

The templates were mistakenly updated to only produce templates for the base module and not the foundation module (see https://cdn.jsdelivr.net/angular-base-apps/1.2.6/base-apps-templates.js). This can be fixed in one of the following ways:

  1. Create a new foundation-apps-templates.js for each 1.2.* release which will duplicate base-apps-templates.js but use the foundation module
  2. Similar to 1, but add the code to the existing base-apps-templates.js files
  3. Add a note to the 1.2.* migration stating that the new base modules must be used
@soumak77
Copy link
Contributor Author

Option 1 has been completed on jsdelivr. I'll update the docs, but if you use the base modules for 1.2.6, you'll need to include base-apps-templates.js and if you use the foundation modules for 1.2.6, you'll need to include foundation-apps-templates.js.

soumak77 added a commit that referenced this issue Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant