Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit on error #46

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Exit on error #46

merged 1 commit into from
Jun 10, 2024

Conversation

coffeejunk
Copy link
Contributor

If any of the (sub)commands in install.sh fail, the install script will continue to run and effectively hide the fact that something went wrong. Setting set -e will make the bash script exit upon an error.

Context: I was just testing #29 in an arm64 VM, and the installation of mise failed silently (because the current version does not have a code path for arm64); however, it appeared as if the installation had worked correctly and I got logged out at the end of it.
Then, when I tried to log in again, the system would simply hang. Upon further inspection, I realized it was hanging on this prompt:

gum confirm "You're missing mise (replacement for rbenv + nodenv). Install now?" && \

Screenshot 2024-06-08 at 11 08 22 AM

@iljo-dp
Copy link

iljo-dp commented Jun 8, 2024

I think this is a great catch and I think a great implementation and use of the command, btw the issue in #29 should be fixed

@josephchigiz
Copy link

Yes, this makes for a very important addition.

@dhh dhh merged commit de7e5b4 into basecamp:master Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants