Add input config option for accepted file types #789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale after 90 days of inactivity. It will be closed if no further activity occurs. |
|
keep alive! |
|
This seems fairly straight forward to merge? I would need this feature. |
This was referenced Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an additional config option to restrict the file input dialog to specific mime types.
Any file could still be potentially drag n dropped into the editor, but I believe the best place to deal with that is still the
trix-file-acceptevent. The purpose of this PR is just to add a bit of UX polish to grey out disallowed files in the input dialog.I haven't added any tests as I'm not sure if this functionality can be tested. I couldn't find a way to inspect the file input dialog in tests.
I'm obviously open to any suggestions or comments regarding implementation, design, testing or even necessity :)