Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlocked elasticsearch/elasticsearch version #3

Merged
merged 1 commit into from Feb 21, 2017
Merged

Unlocked elasticsearch/elasticsearch version #3

merged 1 commit into from Feb 21, 2017

Conversation

kkomelin
Copy link
Contributor

@kkomelin kkomelin commented Feb 21, 2017

... so that the package supported versions of elasticsearch/elasticsearch higher than 5.0.0.

I have a conflict with https://github.com/ErickTamayo/laravel-scout-elastic which uses higher version.

... so that the package supports versions of elasticsearch/elasticsearch greater than 5.0.0
@basemkhirat basemkhirat merged commit 4a0a3c3 into basemkhirat:master Feb 21, 2017
@basemkhirat
Copy link
Owner

basemkhirat commented Feb 21, 2017

Thanks @kkomelin but I have a question.
why you want to install ErickTamayo/laravel-scout-elastic with basemkhirat/elasticsearch as you can use basemkhirat/elasticsearch as a laravel scout driver.

@kkomelin
Copy link
Contributor Author

Thank you @basemkhirat for reviewing and merging my PR.

why you want to install ErickTamayo/laravel-scout-elastic with basemkhirat/elasticsearch as you can use basemkhirat/elasticsearch as a laravel scout driver.

Mostly because of this PR ErickTamayo/laravel-scout-elastic#40 which I believe will soon be included in ErickTamayo/laravel-scout-elastic.
The main feature I need for my project is a possibility to create custom mappings for my index types/models, and the PR adds a console command for that.

On the other hand, the search flexibility of your package makes a difference and I would use it for custom search. I'm now working on a distance condition for geo points. Would you accept a PR for that?

@basemkhirat
Copy link
Owner

sure @kkomelin you are welcome for any contributions like that or any contribution that adds a new a new feature has a value.

@basemkhirat
Copy link
Owner

hello @kkomelin,

I took the idea of managing indices using laravel artisan command from thomasjsn/laravel-scout-elastic and add some features such as creating aliases for indices, drop indices and data reindexing command.

see readme.

Hoping to give it a try.

Thanks

@kkomelin
Copy link
Contributor Author

Hi @basemkhirat,
Thank you for making the improvements.
Index aliases is an especially good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants