Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate publishing various artifacts on project version change #206

Merged
merged 5 commits into from
Feb 9, 2023

Conversation

pankajroark
Copy link
Collaborator

  • If truss project version changes then we do the following
    • Create a git tag
    • Build and push context builder image to dockerhub
    • Build and publish truss to pypi
  • Version is always calculated based on truss project version, not picked up from the tag

I've merged the release workflow into main for now, as I'm not sure of the utility of tag triggering a release, we always want to match it to pyproject version. But we can revisit this if see the need for it.

Copy link
Collaborator

@bolasim bolasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also extract the context builder version from this? I think maintaining a separate version here seems redundant

@pankajroark
Copy link
Collaborator Author

Can we also extract the context builder version from this? I think maintaining a separate version here seems redundant

That has more complexities, let me tackle that separately. Main one is that, many changes to truss don't require creating new images, and building/pushing all those images takes about 30 mins. So I'm hesitant to add that for every truss version increment. It needs more thought. Want to go incrementally also. Developing/testing these actions takes surprisingly long.

@pankajroark pankajroark changed the title Automate context builder image creation on version change Automate publishing various artifacts on project version change Feb 8, 2023
Copy link
Collaborator

@howespt howespt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chatting offline around future improvements:

  • make a workflow for manually building images + running integration tests

otherwise lgtm 🏴‍☠️

@pankajroark pankajroark merged commit b9df2d8 into main Feb 9, 2023
@pankajroark pankajroark deleted the pg/ctx-bldr-automation branch February 9, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants