Bring back table_logger fix #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostinyi
approved these changes
Feb 9, 2023
🏴☠️
zero1zero
reviewed
Feb 9, 2023
| # numpy 1.24 onwards, where np.float and np.int have been remove. | ||
| # https://github.com/AleksTk/table-logger/blob/v0.3.6/table_logger/table_logger.py#L80 | ||
| # Monkey patch table_logger here. Ultimately we should move away from kfserving, | ||
| # perhaps to kserve. |
There was a problem hiding this comment.
Just FYI, this comment doesn't seem valid anymore as to the fix for this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If latest numpy is added as a requirement to a truss then that breaks running the image, because latest numpy remove np.float and np.int. We had this fix before but this got removed in this PR: #206, bringing it back