Convert control server from Flask to FastAPI #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostinyi
reviewed
Jun 12, 2023
pankajroark
approved these changes
Jun 13, 2023
* Logging setup from control module. * Try new version.
bolasim
added a commit
that referenced
this pull request
Jun 26, 2023
* Revert "Move inference server from thread to startup of control server (#379)" This reverts commit 9c4f037. * Revert "Fix async issues with control server and use the same Uvicorn setup as inference (#373)" This reverts commit dc0d27f. * Revert "Convert control server from Flask to FastAPI (#358)" This reverts commit 4395d99. * Fix bad dep configuration for builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastAPI offers many performance improvements and allows us to have a consistent approach to various parts of the codebase (serialization middleware, etc).
Integration tests are passing: https://github.com/basetenlabs/truss/actions/runs/5247629590