Revert control server to Flask instead of FastAPI #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolasim
force-pushed
the
bola/revert-control-fastapi
branch
5 times, most recently
from
7d8651b
to
717c23c
Compare
This reverts commit 4395d99.
bolasim
force-pushed
the
bola/revert-control-fastapi
branch
from
717c23c
to
8b12ac8
Compare
|
Integration tests run: https://github.com/basetenlabs/truss/actions/runs/5367244355/jobs/9737250032 |
bolasim
requested review from
pankajroark and
joostinyi
and removed request for
pankajroark
squidarth
approved these changes
Jun 25, 2023
bolasim
force-pushed
the
bola/revert-control-fastapi
branch
from
acbe169
to
d740084
Compare
pankajroark
approved these changes
Jun 26, 2023
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While my intentions were good (to increase performance thanks to FastAPI and unify some code with the inference server), this changed caused quite a few issues due to the async nature of the new control server that led to some race conditions while patching and restarting the inference server.
For now, let's revert and get back to this once we can properly test it for these race conditions.
Integration tests: https://github.com/basetenlabs/truss/actions/runs/5370661024