Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GCS -> GCP. #880

Merged
merged 1 commit into from Mar 27, 2024
Merged

Rename GCS -> GCP. #880

merged 1 commit into from Mar 27, 2024

Conversation

squidarth
Copy link
Collaborator

馃殌 What

Follow-up from this change: https://github.com/basetenlabs/baseten/pull/8198. Originally called the option "GCS", but realized that that is specifically "Google Cloud Storage", which this does not refer to.

This should go out in conjunction with https://github.com/basetenlabs/baseten/pull/8213

馃捇 How

馃敩 Testing

See https://github.com/basetenlabs/baseten/pull/8198 for the full testing instructions

@squidarth squidarth merged commit c4b2d19 into main Mar 27, 2024
3 checks passed
@squidarth squidarth deleted the sshanker/rename-setting-name branch March 27, 2024 12:55
@squidarth squidarth mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants