Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename GCS -> GCP. #880

Merged
merged 1 commit into from Mar 27, 2024
Merged

Rename GCS -> GCP. #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions truss/tests/test_config.py
View file
Open in desktop
Expand Up @@ -118,7 +118,7 @@ def test_acc_spec_from_str(input_str, expected_acc):
"image": "custom_base_image",
"python_executable_path": "/path/python",
"docker_auth": {
"auth_method": "GCS_SERVICE_ACCOUNT_JSON",
"auth_method": "GCP_SERVICE_ACCOUNT_JSON",
"secret_name": "some-secret-name",
"registry": "some-docker-registry",
},
Expand All @@ -127,7 +127,7 @@ def test_acc_spec_from_str(input_str, expected_acc):
image="custom_base_image",
python_executable_path="/path/python",
docker_auth=DockerAuthSettings(
auth_method=DockerAuthType.GCS_SERVICE_ACCOUNT_JSON,
auth_method=DockerAuthType.GCP_SERVICE_ACCOUNT_JSON,
secret_name="some-secret-name",
registry="some-docker-registry",
),
Expand All @@ -136,7 +136,7 @@ def test_acc_spec_from_str(input_str, expected_acc):
"image": "custom_base_image",
"python_executable_path": "/path/python",
"docker_auth": {
"auth_method": "GCS_SERVICE_ACCOUNT_JSON",
"auth_method": "GCP_SERVICE_ACCOUNT_JSON",
"secret_name": "some-secret-name",
"registry": "some-docker-registry",
},
Expand Down
2 changes: 1 addition & 1 deletion truss/truss_config.py
View file
Open in desktop
Expand Up @@ -303,7 +303,7 @@ class DockerAuthType(Enum):
authentication we support.
"""

GCS_SERVICE_ACCOUNT_JSON = "GCS_SERVICE_ACCOUNT_JSON"
GCP_SERVICE_ACCOUNT_JSON = "GCP_SERVICE_ACCOUNT_JSON"


@dataclass
Expand Down