Change default Bitcask I/O mode to Erlang #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional testing demonstrates that using Erlang's built-in I/O provides more consistent behavior than the synchronous NIF approach. While the NIF approach is known to provide higher throughput, the non-deterministic impact on the Erlang VM from the use of blocking NIFs outweighs the benefit. Defaulting to the safer option. Users can manually revert to using NIFs if desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional testing demonstrates that using Erlang's built-in I/O
provides more consistent behavior than the synchronous NIF approach.
While the NIF approach is known to provide higher throughput, the
non-deterministic impact on the Erlang VM from the use of blocking
NIFs outweighs the benefit. Defaulting to the safer option. Users
can manually revert to using NIFs if desired.