Fixed show, set command arguments. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much, @Licenser! Not sure how this one slipped past us. Your fix looks great, and is much appreciated. |
nickelization
added a commit
that referenced
this pull request
Jul 10, 2015
Fixed show, set command arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell: show, set, describe - the clique internal arguments get a special treatment as they behave differently then other commands.
cmd_specis use to generate a wrapper to prevent some of the processing to be done on the arguments.The returned function had the arity of
2howeverclique_command:runexpects a function with the arity of3. The patch returns a function of the arity of3by simply ignoring the first argument.