Add riak_cli_handler behaviour #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjstone
force-pushed
the
feature/riak_cli_behaviour
branch
from
9e4358a
to
ba10a59
Compare
Allow a centralized place for registering modules with riak_cli:register/1. Each of those modules implements the riak_cli_handler behaviour and should call other registration functions as needed.
andrewjstone
force-pushed
the
feature/riak_cli_behaviour
branch
from
ba10a59
to
460f6e9
Compare
|
Fixed and rebased per @JeetKunDoug's comment. |
andrewjstone
added a commit
that referenced
this pull request
Dec 4, 2014
Add riak_cli_handler behaviour
|
|
||
| -behaviour(riak_cli_handler). | ||
|
|
||
| register_cli() -> |
There was a problem hiding this comment.
Looks like the callback is defined as register() but in the docs its register_cli()? Am I misunderstanding?
There was a problem hiding this comment.
Nope, just a bug on my part. fixing....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a centralized place for registering modules with
riak_cli:register/1. Each of those modules implements the
riak_cli_handler behaviour and should call other registration functions
as needed.