Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jfw return value rodeo #45

Merged
merged 8 commits into from
Dec 20, 2012
Merged

Jfw return value rodeo #45

merged 8 commits into from
Dec 20, 2012

Conversation

chardan
Copy link
Contributor

@chardan chardan commented Dec 20, 2012

Fix regression with riak_kv.

@ghost ghost assigned slfritchie Dec 20, 2012
@slfritchie
Copy link
Contributor

The basics look good. TravisCI's unit tests are passing.

One thing before final review: a second combing of the -specs in src/eleveldb.erl are in order.

  1. Check that the return values from the async work items match. Jesse and I have already gone through some but not all.
  2. Add the type for the "ER" returned when the async job submission fails. Perhaps add a -type async_failure() :: whatever_the_ER_thingie_looks_like() and then add async_failure() as an option to the return value spec for each of the async functions?

chardan pushed a commit that referenced this pull request Dec 20, 2012
@chardan chardan merged commit ad34d81 into master Dec 20, 2012
@ghost ghost assigned chardan Dec 20, 2012
@seancribbs seancribbs deleted the jfw-return_value_rodeo branch April 1, 2015 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants