Replace FILE* functions with their file descriptor equivalents #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FILE* functions are limited by FOPEN_MAX. On FreeBSD 10.1, this is SHRT_MAX (32767). Unfortunately, on a busy server with lots of memory, this limit could easily be hit. Note that open sockets and files opened by open system call variants also count towards this limit. This replacement is actually better for logging as we directly write to file instead of fwrite followed by fflush.
|
Basho has closed down. Doubt anyone has access to merge the PR. Just letting you know. |
|
Thanks @matthewvon for letting me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FILE* functions are limited by FOPEN_MAX. On FreeBSD 10.1, this is
SHRT_MAX (32767). Unfortunately, on a busy server with lots of memory,
this limit could easily be hit. Note that open sockets and files opened
by open system call variants also count towards this limit. This
replacement is actually better for logging as we directly write to
file instead of fwrite followed by fflush.