Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing whoami with id -un to be more POSIX.2 compliant [JIRA: TOOLS-143] #186

Merged
merged 1 commit into from
Sep 28, 2015

Conversation

drewkerrigan
Copy link
Contributor

Per the suggestion in the comments from #185, replacing the questionably supported whoami with id -un for collecting the current user for execution scripts.

Reference: http://pubs.opengroup.org/onlinepubs/007908799/xcu/id.html

@DSomogyi
Copy link

create jira issue

@Basho-JIRA Basho-JIRA changed the title Replacing whoami with id -un to be more POSIX.2 compliant Review submitted PR [JIRA: TOOLS-143] Aug 25, 2015
@DSomogyi DSomogyi changed the title Review submitted PR [JIRA: TOOLS-143] Replacing whoami with id -un to be more POSIX.2 compliant [JIRA: TOOLS-143] Sep 14, 2015
davidx added a commit that referenced this pull request Sep 28, 2015
Replacing whoami with id -un to be more POSIX.2 compliant [JIRA: TOOLS-143]
@davidx davidx merged commit d409557 into develop Sep 28, 2015
@Basho-JIRA
Copy link

merged [done]

_[posted via JIRA by David Andersen]_

@jaredmorrow
Copy link
Contributor

There was a reason id -un wasn't used and it was due to the continuing support of Solaris 10. Solaris 10 does not have -u as an option in /usr/bin/id.

# id -un
id: illegal option -- u
Usage: id [-ap] [user]

There are some weird things in node_package that don't seem to make any sense, but most of them are due to the original support of Solaris 10 and it's billion-year-old userland.

You can fix this by going back to whoami which I tested originally and is supported on all the destination OS's Riak supports. Or you can add /usr/xpg4/bin to the head of the path in the solaris package only. The problem with that is you'll now get all new EVERYTHING so you'll have to test it on Solaris 10, which is as fun as it sounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants