Fix queue/0 type deprecations (with queue:queue/0) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbbx6spp
force-pushed
the
fix-R18-deprecations
branch
2 times, most recently
from
3f9949d
to
ea82c42
Compare
When including the latest on `basho:develop` for poolboy as a dependency in an Erlang project, rebar aborted with a warning as error with the following messages: ``` /Users/susan.potter/Code/oss/carson/deps/poolboy/src/poolboy.erl:24: type queue/0 is deprecated and will be removed in OTP 18.0; use use queue:queue/0 or preferably queue:queue/1 /Users/susan.potter/Code/oss/carson/deps/poolboy/src/poolboy.erl:25: type queue/0 is deprecated and will be removed in OTP 18.0; use use queue:queue/0 or preferably queue:queue/1 ERROR: compile failed while processing /Users/susan.potter/Code/oss/carson/deps/poolboy: rebar_abort ``` *This pull request addresses the above deprecations so I can build keeping with `warnings_as_errors` on, which I prefer. This might break compatibility with much older versions of Erlang but for practical purposes I do not believe this will pose a problem for versions that poolboy wishes to support.* This is the [erlang-questions ML thread] [1] where Andreas Schumacher outlines the deprecation warnings in R17 to prepare the way for R18.0. [1]: http://erlang.org/pipermail/erlang-questions/2014-March/078081.html "R18.0 type deprecations"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When including the latest on
developfor poolboy as a dependency in an Erlang project, rebar aborted with a warning as error with the following messages:This pull request addresses the above deprecations so I can build keeping with
warnings_as_errorson, which I prefer. This might break compatibility with much older versions of Erlang but for practical purposes I do not believe this will pose a problem for versions that poolboy wishes to support.This is the erlang-questions ML thread where Andreas Schumacher
outlines the deprecation warnings in R17 to prepare the way for R18.0.