Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix queue/0 type deprecations (with queue:queue/0) #6

Closed
wants to merge 1 commit into from
Closed

Fix queue/0 type deprecations (with queue:queue/0) #6

wants to merge 1 commit into from

Commits on Nov 6, 2014

  1. Fix queue/0 type deprecations (with queue:queue/0) 

    When including the latest on `basho:develop` for poolboy as a dependency in
an Erlang project, rebar aborted with a warning as error with the following
messages:

```
/Users/susan.potter/Code/oss/carson/deps/poolboy/src/poolboy.erl:24: type queue/0 is deprecated and will be removed in
OTP 18.0; use use queue:queue/0 or preferably queue:queue/1
/Users/susan.potter/Code/oss/carson/deps/poolboy/src/poolboy.erl:25: type queue/0 is deprecated and will be removed in
OTP 18.0; use use queue:queue/0 or preferably queue:queue/1
ERROR: compile failed while processing /Users/susan.potter/Code/oss/carson/deps/poolboy: rebar_abort
```

*This pull request addresses the above deprecations so I can build keeping
with `warnings_as_errors` on, which I prefer. This might break compatibility
with much older versions of Erlang but for practical purposes I do not believe
this will pose a problem for versions that poolboy wishes to support.*

This is the [erlang-questions ML thread] [1] where Andreas Schumacher
outlines the deprecation warnings in R17 to prepare the way for R18.0.

[1]: http://erlang.org/pipermail/erlang-questions/2014-March/078081.html "R18.0 type deprecations"
    Susan Potter committed Nov 6, 2014
    Configuration menu
    Copy the full SHA
    ea82c42 View commit details
    Browse the repository at this point in the history