Escape '|' in the Windows runner usage string #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows simplenode runner template prints a usage string that contains the pipe character '|'. That character needs to be escaped with a caret '^' otherwise the script will try to perform shell command piping when printing its usage. Tested on Windows 7.
|
Thanks for the info! For some reason I had not been able to find what the correct escape character for cmd.exe was. I'll include this fix in #194, since the usage message also changes there. |
|
Closing this pull request since the change got applied in 3894f28 by xenolinguist, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows simplenode runner template prints a usage string that
contains the pipe character '|'. That character needs to be escaped with
a caret '^' otherwise the script will try to perform shell command
piping when printing its usage. Tested on Windows 7.