More appropriate method to check Reltools version. #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If running e.g. rebar generate using an OTP development build, rebar will complain that reltool has the version "", which is less than the required "0.5.2". This is because rebar_reltool simply checks the path returned by code:which(reltool), which doesn't yield version information if used in a development build. This patch substitutes a more robust method (load reltool and fetch the info from application:loaded_applications(). As it happens, this will not be enough to make things work, but now Reltool will explain that it cannot generate a spec from a system that is not installed, giving a better hint as to what needs to be done.
|
Thanks, merged. |
ghost
closed this
mattsta
pushed a commit
to mattsta/rebar
that referenced
this pull request
Jun 21, 2014
Use lowercase for Windows drive name to resolve issue basho#250
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If running e.g. rebar generate using an OTP development build,
rebar will complain that reltool has the version "", which is
less than the required "0.5.2". This is because rebar_reltool
simply checks the path returned by code:which(reltool), which
doesn't yield version information if used in a development build.
This patch substitutes a more robust method (load reltool and
fetch the info from application:loaded_applications().
As it happens, this will not be enough to make things work,
but now Reltool will explain that it cannot generate a spec
from a system that is not installed, giving a better hint
as to what needs to be done.