Skip to content
This repository

Restore ability to specify deps_dir on the command line #311

Closed
wants to merge 1 commit into from

3 participants

Yurii Rashkovskii José Valim Tuncer Ayaz
Yurii Rashkovskii

It was previously possible to run rebar compile deps_dir=/path/to/deps,
as of 70d27c5, it was nixed.

This commit fixes this problem.

Yurii Rashkovskii

@tuncer, Mix from Elixir relies heavily on being able to pass deps_dir to rebar when compiling rebar dependencies.

If you think about it, it does make a lot of sense to allow modifying deps_dir without touching rebar.config in cases when you want to manipulate the storage of dependencies in some unusual way.

/cc @josevalim

Yurii Rashkovskii Restore ability to specify deps_dir on the command line
It was previously possible to run `rebar compile deps_dir=/path/to/deps`,
but as of 70d27c5, it was nixed.
e7172e8
José Valim

:+1: As @yrashk said, we use deps_dir= as a way to move both Mix and Rebar dependencies into a directory shared between both.

Tuncer Ayaz

Thanks, merged.

Tuncer Ayaz tuncer closed this September 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Sep 12, 2012
Yurii Rashkovskii Restore ability to specify deps_dir on the command line
It was previously possible to run `rebar compile deps_dir=/path/to/deps`,
but as of 70d27c5, it was nixed.
e7172e8
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 2 additions and 1 deletion. Show diff stats Hide diff stats

  1. 3  src/rebar_deps.erl
3  src/rebar_deps.erl
@@ -185,7 +185,8 @@ setup_env(Config) ->
185 185
 %% Sets a default if root config has no deps_dir set
186 186
 set_shared_deps_dir(Config, []) ->
187 187
     rebar_config:set_xconf(Config, deps_dir,
188  
-                           rebar_config:get_local(Config, deps_dir, "deps"));
  188
+                           rebar_config:get_local(Config, deps_dir, 
  189
+                            rebar_config:get_global(Config, deps_dir, "deps")));
189 190
 set_shared_deps_dir(Config, _DepsDir) ->
190 191
     Config.
191 192
 
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.