WIP: .NET client rewrite #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukebakken
commented
Jun 25, 2016
•
lukebakken
commented
- CLIENTS-606
- CLIENTS-621
Updated .NET Framework target version to 4.6 Fix build errors around deprecated features
…se are pointless. Add Connection class and begin adding tests. Implementing Connection class and unit / integration tests. Async connection integration test FTW Implementing classes to Write / Read commands from streams in correct PBC format. Add test to write FetchPreflist request to memory stream and compare bytes written by CommandWriter. Working on reading Riak responses. Add MessageReader. Result is not the same as Response. Mono build fixes Implementing first part of MessageReader tests - read an RpbErrorResp Test to decode Riak response added and successful. First test of reading a streaming response is written and complete. Writing to a closed socket throws IOException
READY: Async Connection class
Nuke the Timeout since TimeSpan works just fine. Remove copyright headers. Working on porting ConnectionManager from Go and adding tests. Ensure Connection state available after disposal.
Connection Manager (connection pool)
NodeOptions and tests complete Fix a deadlock. Working on Node class and tests Node work in progress. Review code for correct use of ReaderWriterLockSlim ONLY outside async / await
Improve connection tests.
# Conflicts:
# src/RiakClient/Commands/CRDT/DataTypeResponse{TValue}.cs
# src/RiakClient/Commands/CRDT/FetchCommandBuilder{TBuilder,TCommand,TOptions,TResponse}.cs
# src/RiakClient/Commands/CRDT/FetchCommand{TResponse}.cs
# src/RiakClient/Commands/CRDT/UpdateCommandBuilder{TBuilder,TCommand,TOptions,TResponse}.cs
# src/RiakClient/Commands/CRDT/UpdateCommandOptions.cs
# src/RiakClient/Commands/CRDT/UpdateCounter.cs
# src/RiakClient/Commands/CRDT/UpdateCounterOptions.cs
# src/RiakClient/Commands/CRDT/UpdateMap.cs
# src/RiakClient/Commands/CRDT/UpdateSet.cs
# src/RiakClient/Commands/CommandBuilder{TBuilder,TCommand,TOptions}.cs
# src/RiakClient/Commands/CommandOptions.cs
# src/RiakClient/Commands/Command{TOptions,TResponse}.cs
# src/RiakClient/Commands/Command{TResponse}.cs
# src/RiakClient/Commands/IRiakCommand.cs
# src/RiakClient/Commands/KV/FetchPreflist.cs
# src/RiakClient/Commands/KV/PreflistResponse.cs
# src/RiakClient/Commands/Response.cs
# src/RiakClient/Commands/Response{TValue}.cs
# src/RiakClient/Commands/ServerInfoResponse.cs
# src/RiakClient/Comms/RiakPbcSocket.cs
# src/RiakClient/Core/SecurityManager.cs
# src/RiakClient/Messages/RpbClasses.cs
# src/RiakClient/Messages/riak_dt.cs
# src/RiakClient/Messages/riak_ts.cs
# src/RiakClient/Models/RiakDeleteOptions.cs
# src/RiakClient/Models/RiakOptions.cs
# src/RiakClient/RiakClient.cs
# src/RiakClientTests.Live/App.config
# src/RiakClientTests.Live/DataTypes/BasicMapFlagDtTests.cs
# src/RiakClientTests.Live/RiakConfigurationTests.cs
# src/Test/App.config
# src/Test/Traits.cs
# src/Test/packages.config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.