Timeout support for list keys and buckets #100
Conversation
ghost
assigned backwards compatibility
| @@ -1100,14 +1129,24 @@ process_response(#request{msg = #rpbdelreq{}}, | |||
There was a problem hiding this comment.
This is subjective so feel free to completely ignore this comment, but I think this function is too long and would be easier to understand if refactored to use a couple of function calls. e.g. maybe_send_caller and process_response_reply. Another option I would like better would be to use a few function clauses to replace the case statements.
There was a problem hiding this comment.
This is copied directly from the key-listing clause below it. I really with that erlang allowed conjunctions in it's pattern-matching, it'd simplify a lot of code. But the, I wish a lot of things about erlang. I'll see if I can make both of them a bit cleaner.
There was a problem hiding this comment.
Actually, I am just going to clean up mine, since the old one seems to work, and I don't know the history/backwards compatibility requirements. But since there is no history for mine I can guarantee that buckets and done will never be set in the same response, so can simplify it down to two clauses.
|
updated. |
|
+1 to merge |
Timeout support for list keys and buckets
add: