add get_preflist to http-client #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2015
Closed
zeeshanlakhani
force-pushed
the
feature/zl/add-get-preflist
branch
from
10f931c
to
07bce98
Compare
This was referenced Feb 16, 2015
|
I have similar comments on the PB client. I'm most concerned about the lists-of-lists thing. Maybe it's not a significant detail. |
zeeshanlakhani
force-pushed
the
feature/zl/add-get-preflist
branch
2 times, most recently
from
4d8430c
to
88a46f2
Compare
| %% @doc Convert a preflist resource response to a proplist. | ||
| erlify_preflist(Response) -> | ||
| Preflist = [V || {_, V} <- proplists:get_value(<<"preflist">>, Response)], | ||
| lists:foldl( |
There was a problem hiding this comment.
This can be simplified to a list comprehension.
[ lists:foldl(fun({K, V}, AccRec) -> erlify_preflist(K, V, AccRec) end, #preflist_item{}, P) || P <- Preflist ]
zeeshanlakhani
force-pushed
the
feature/zl/add-get-preflist
branch
from
88a46f2
to
2165137
Compare
|
@seancribbs I plan to also update rebar.config to use the newest webmachine/ibrowse versions... and once basho/riak-erlang-client#204 is in, I guess we should tag a release there, yeah? |
|
👍 (merge manually) |
|
@seancribbs will do. |
zeeshanlakhani
added a commit
that referenced
this pull request
Feb 27, 2015
add get_preflist to http-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of RIAK-1481.
The active preflist will return primary/fallback partitions and nodes for the available nodes at the time of query. Primary/fallback will be annotated.
This involves updates to our RiakKV WB code, RiakPB, Riak-Erlang-Http-Client, Riak-Erlang-Client.
*The impetus for adding this to the API started with a mailing list question answered by Charlie Voiselle, http://lists.basho.com/pipermail/riak-users_lists.basho.com/2015-January/016527.html, which involved a snippet of code that we've given clients multiple times. This was then discussed with Russell Brown on HipChat, https://basho.hipchat.com/history/room/867200/2015/01/13?q=enterprising&t=rid-867200#12:23:22.
Other PRs in the series: