Date speedup #159
Merged
Date speedup #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache httpclient 4.1.x uses { RFC1036, RFC1123, ASCTIME }, and uses
java.text.SimpleDateFormat#parse(String), which raises an exception
on failure. Since the Riak server uses RFC1123, this ordering
is faster -- we avoid the creation of a ParseException during the
failed RFC1036 parse.
See https://issues.apache.org/jira/browse/HTTPCLIENT-1227 for details.
|
Looks like this will be resolved in HttpClient 4.2.2, and in the 4.3.x branch. So upgrading your dependency to 4.2.2 once it becomes available will also resolve the issue. I'm not sure what their schedule is. |
ghost
assigned
broach
pushed a commit
that referenced
this pull request
Sep 4, 2012
Looks good, thanks. Merging this into 1.0.6 which I'll cut as a public release this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache httpclient 4.1.x uses { RFC1036, RFC1123, ASCTIME }, and uses java.text.SimpleDateFormat#parse(String), which raises an exception on failure. Since the Riak server uses RFC1123, this ordering is faster -- we avoid the creation of a ParseException during the failed RFC1036 parse.
See https://issues.apache.org/jira/browse/HTTPCLIENT-1227 for details.