READY: Remove "callback" from all Joi schemas. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 10, 2015 08:13
Wrote tests to ensure that withCallback() works when build() is called in a Builder. Removed EOL whitespace.
lukebakken
changed the title
lukebakken
added a commit
that referenced
this pull request
Apr 13, 2015
READY: Remove "callback" from all Joi schemas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
callbackin the schema confused me several times into thinking that was a valid way to specify the callback for an operation.This will remove that from the schema but uses
deleteto achieve the same thing withinBuilderclasses.I also nuked a bunch of end-of-line whitespace so I recommend adding
?w=1to the URL when reviewing the diffs for this PR.