riak stop does not behave properly on BSD systems
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Adds `getpid` as a way to get the PID of the running node. This also options that were missing from the usage text. Supports #251
In BSD systems the regular expression was failing that attempted to capture the PID of the running Riak node. This PID was used in the `riak stop` command to properly wait for a node to stop. This change fixes the situation by replacing the fragile shell methods of getting the PID with an erlang / nodetool based method. In addtion a `riak getpid` function has been added for general admin use. Addresses #251
jaredmorrow
added a commit
to basho/riak_test
that referenced
this pull request
Dec 5, 2012
This test functionality added to address PID issues found on FreeBSD using riak_test. The issue was addressed in basho/riak#251
|
Test added to basho/riak_test here basho/riak_test#116 |
|
Not only do I like it, but it totally works via riak_test and manual devrel testing. +1 |
jaredmorrow
added a commit
that referenced
this pull request
Dec 5, 2012
`riak stop` does not behave properly on BSD systems
hmmr
pushed a commit
that referenced
this pull request
Nov 8, 2016
Adds `getpid` as a way to get the PID of the running node. This also options that were missing from the usage text. Supports #251
hmmr
pushed a commit
that referenced
this pull request
Nov 8, 2016
In BSD systems the regular expression was failing that attempted to capture the PID of the running Riak node. This PID was used in the `riak stop` command to properly wait for a node to stop. This change fixes the situation by replacing the fragile shell methods of getting the PID with an erlang / nodetool based method. In addtion a `riak getpid` function has been added for general admin use. Addresses #251
martincox
pushed a commit
that referenced
this pull request
Jan 31, 2022
Extend the FetchClockNVal message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
riak stopin BSD systems a regular expression was failing that attempted to capture the PID of the running Riak node. This PID was used in theriak stopcommand to properly wait for a node to stop completely before returning.The user experience resulted in the following situation:
The expected behavior is like that on Linux,
riak stopshould not return until Riak is fully stopped.