erl scripts #1049
Merged
erl scripts #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some riak admin scripts require an erlang node to be started, and then connected to the riak node (rather than using rpc). These scripts don't work in 3.0.1. $ERTS_PATH and $NAME_PARAM are not defined (as was previously defined in node_package); boot file - cannot find start.boot only start_clean.boot (for reasons unknown); observer not an installed application These changes work with OTP 20.3, OTP 21.3 and OTP 22.3. Tested using: `make rel` `rel/riak/bin/riak start` `rel/riak/bin/riak admin top`
There was a special formatetr for etop packaged within riak top. This may have been visually more appealing? However, going forward want to take advantage of mainstream OTP improvements not rely on bespoke formatter. May not have been working anyway.
Bob-The-Marauder
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some riak admin scripts require an erlang node to be started, and then connected to the riak node (rather than using rpc).
These scripts don't work in 3.0.1.
$ERTS_PATH and $NAME_PARAM are not defined (as was previously defined in node_package);
boot file - cannot find start.boot only start_clean.boot (for reasons unknown);
observer not an installed application
These changes work with OTP 20.3, OTP 21.3 and OTP 22.3. Tested using:
make relrel/riak/bin/riak startrel/riak/bin/riak admin top