Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on leveldb developer mode when building devrels #462

Merged
merged 1 commit into from Dec 31, 2013

Conversation

Vagabond
Copy link
Contributor

I don't know if I did this right, but it seems to work? Without this all the replication tests on giddyup fail because when the 5th or 6th node starts the VM is out of RAM.

cc @jaredmorrow @joedevivo @matthewvon

@joedevivo
Copy link
Contributor

There's an easier way to do this without duplicating code:

{mapping, "leveldb.limited_developer_mem", "eleveldb.limited_developer_mem", [
  {default, true},
  merge
]},

What you're telling the fish is "I've already defined limited_developer_mem, but I just want this one part to override.

This way you don't have to copy the @doc and make sure it stays in sync with the leveldb schema.

@Vagabond
Copy link
Contributor Author

If I do:

{{#devrel}}
{mapping, "leveldb.limited_developer_mem", "eleveldb.limited_developer_mem", [
  {default, true},
  {level, basic},
  merge
]}.
{{/devrel}}

I get

{mapping, "leveldb.limited_developer_mem", "eleveldb.limited_developer_mem", [
  {default, true},
  {level, basic},
  merge
]}.

Which causes:

ERROR: generate failed while processing /home/andrew/riak/rel: {'EXIT',
    {badarg,
        [{io_lib,format,
             ["Default: ~s",
              [{error,
                   "Tried to convert true, an invalid datatype string to_string."}]],
             [{file,"io_lib.erl"},{line,155}]},
         {cuttlefish_conf,generate_comments,1,
             [{file,"src/cuttlefish_conf.erl"},{line,125}]},
         {cuttlefish_conf,generate_element,1,
             [{file,"src/cuttlefish_conf.erl"},{line,108}]},
         {cuttlefish_conf,'-generate/1-fun-0-',2,
             [{file,"src/cuttlefish_conf.erl"},{line,71}]},
         {lists,foldl,3,[{file,"lists.erl"},{line,1248}]},
         {cuttlefish_conf,generate_file,2,

@joedevivo
Copy link
Contributor

+1, I'll make another PR to make this less repeaty in the future.

@jaredmorrow
Copy link
Contributor

Don't forget to apply this to riak_ee as well.

Vagabond added a commit that referenced this pull request Dec 31, 2013
Turn on leveldb developer mode when building devrels
@Vagabond Vagabond merged commit a968f00 into develop Dec 31, 2013
@hazen hazen deleted the adt-devrel-developer branch February 26, 2016 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants