Make the dependency calculation a bit more sane, excluding circular d…

…eps.
basho · Aug 20, 2012 · 300965c · 300965c
1 parent d5f707f
commit 300965c
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/test/pb_service_test.erl b/test/pb_service_test.erl
@@ -215,11 +215,12 @@ dep_apps(App) ->
     {ok, Apps} = application:get_key(App, applications),
     Apps.
 
-all_deps(App) ->
-    [[ all_deps(Dep) || Dep <- dep_apps(App) ],App].
+all_deps(App, Deps) ->
+    [[ all_deps(Dep, [App|Deps]) || Dep <- dep_apps(App),
+                                    not lists:member(Dep, Deps)], App].
 
 resolve_deps(App) ->
-    DepList = lists:flatten(all_deps(App)),
+    DepList = all_deps(App, []),
     {AppOrder, _} = lists:foldl(fun(A,{List,Set}) ->
                                         case sets:is_element(A, Set) of
                                             true ->