Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a default selection. #88

Merged
merged 3 commits into from
May 1, 2013
Merged

Conversation

cmeiklejohn
Copy link
Contributor

Addresses #85.

@seancribbs I think this addresses the problem you saw, confirm?

@seancribbs
Copy link

Generally 👍 except for the anomaly discussed in hipchat: parent display is not updated with the selected value.

@jgnewman
Copy link
Contributor

Just added some Ember code to fix the select menus in the current cluster items.

@cmeiklejohn
Copy link
Contributor Author

I'm 👍 with this for now until we upgrade Ember and refactor it -- @seancribbs?

@seancribbs
Copy link

I think I would feel better if the prev() call used a selector instead of relying on the fact that the background element is two previous, e.g. prev('.gui-dropdown-bg'). The more thorough (and less error-prone) way would be to bind that text to a property of the view, controller or model, but I understand that's a bit too much for this fix.

@jgnewman
Copy link
Contributor

jgnewman commented May 1, 2013

@seancribbs Good call. I just made this change. .prev('.gui-dropdown-bg') doesn't actually work so what I did was .parent().find('.gui-dropdown-bg'). This way there's no mistaking which element we're hitting.

@seancribbs
Copy link

@jgnewman good call 😄

@cmeiklejohn
Copy link
Contributor Author

We good to merge on this?

@cmeiklejohn
Copy link
Contributor Author

If so, we also have to merge into 1.4 branch as well.

@seancribbs
Copy link

yeah, I'm 👍

cmeiklejohn added a commit that referenced this pull request May 1, 2013
@cmeiklejohn cmeiklejohn merged commit 1b30368 into master May 1, 2013
@cmeiklejohn cmeiklejohn deleted the csm-default-replacement branch May 1, 2013 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants