Provide a default selection. #88

Merged
merged 3 commits into from May 1, 2013

3 participants

@cmeiklejohn

Addresses #85.

@seancribbs I think this addresses the problem you saw, confirm?

@seancribbs

Generally 👍 except for the anomaly discussed in hipchat: parent display is not updated with the selected value.

@jgnewman

Just added some Ember code to fix the select menus in the current cluster items.

@cmeiklejohn

I'm 👍 with this for now until we upgrade Ember and refactor it -- @seancribbs?

@seancribbs

I think I would feel better if the prev() call used a selector instead of relying on the fact that the background element is two previous, e.g. prev('.gui-dropdown-bg'). The more thorough (and less error-prone) way would be to bind that text to a property of the view, controller or model, but I understand that's a bit too much for this fix.

@jgnewman

@seancribbs Good call. I just made this change. .prev('.gui-dropdown-bg') doesn't actually work so what I did was .parent().find('.gui-dropdown-bg'). This way there's no mistaking which element we're hitting.

@seancribbs

@jgnewman good call 😄

@cmeiklejohn

We good to merge on this?

@cmeiklejohn

If so, we also have to merge into 1.4 branch as well.

@seancribbs

yeah, I'm 👍

@cmeiklejohn cmeiklejohn merged commit 1b30368 into master May 1, 2013

1 check passed

Details default The Travis build passed
@cmeiklejohn cmeiklejohn deleted the csm-default-replacement branch May 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment