Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eunit test for private_dir/0 (and cleanup some whitespace). #141

Merged
merged 2 commits into from
Feb 9, 2012

Conversation

seancribbs
Copy link
Contributor

This is a follow-up to AZ1072, adding an eunit test for the private_dir/0 function.

@jaredmorrow
Copy link
Contributor

Doesn't compile on builders: http://buildbot-master.den.basho:8010/builders/test-riak_core/builds/55/steps/shell_3/logs/stdio

To reproduce, clone into a name that isn't the : git clone git@github.com:basho/riak_core builder

@seancribbs
Copy link
Contributor Author

This comes from an -include_lib that is broken, see https://gist.github.com/1753157. Needs to be fixed, but not related to this PR.

@seancribbs
Copy link
Contributor Author

@jaredmorrow Fixed all include_lib statements of riak_core header files so they use include instead. Builds properly now on a checkout to a differently-named directory.

@jaredmorrow
Copy link
Contributor

+1 compiles cleanly now on buildbot http://buildbot-master.den.basho:8010/builders/test-riak_core/builds/56

seancribbs added a commit that referenced this pull request Feb 9, 2012
Add eunit test for private_dir/0 (and cleanup some whitespace).
@seancribbs seancribbs merged commit 20cfd36 into master Feb 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants