Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vnode shutdown message severity should be info #246

Merged
merged 3 commits into from
Nov 14, 2012

Conversation

slfritchie
Copy link
Contributor

Currently, when a vnode is shutdown, it's possible for handoffs in progress to be aborted and generate a warning severity message like this:

2012-10-26 20:22:09.489 UTC [error] <0.7853.42>@riak_core_handoff_sender:start_fold:215 ownership_handoff transfer of riak_kv_vnode from 'riak@10.10.0.51' 158424493890361546797469742608893960138484875264 to 'riak@10.10.0.53' 158424493890361546797469742608893960138484875264 failed because of error:{badmatch,{error,vnode_shutdown}} [{riak_core_handoff_sender,start_fold,5,[{file,"src/riak_core_handoff_sender.erl"},{line,161}]}]

This PR changes the error severity to an info message and also omits the stack trace, see below for an example.

There are two extra commits here, one to add a bit of bogus demo code to simulate the vnode shutdown without resorting to trying to provoke a race (in case any reviewer were curious). The other commit removes that code. The tell-tale sign that the artificial trigger is hit and the new info severity response looks like this:

2012-10-26 19:08:47.897 [warning] <0.26559.0> Ha, caught a FOO {riak_core_fold_req_v1,#Fun<riak_core_handoff_sender.1..........
2012-10-26 19:08:47.897 [info] <0.27857.0>@riak_core_handoff_sender:start_fold:161 ownership_handoff transfer of riak_kv_vnode from 'dev3@127.0.0.1' 296867520082839655260123481645494988367611297792 to dev4@127.0.0.1' 296867520082839655260123481645494988367611297792 failed because the local vnode was shutdown

@kellymclaughlin
Copy link
Contributor

Looks good. +1 to merge.

@ghost ghost assigned slfritchie Nov 14, 2012
slfritchie added a commit that referenced this pull request Nov 14, 2012
Vnode shutdown message severity should be info
@slfritchie slfritchie merged commit 443d29b into master Nov 14, 2012
@seancribbs seancribbs deleted the slf-vnode_shutdown-no-spam branch April 1, 2015 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants