Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary function call. #285

Merged
merged 1 commit into from
Jul 12, 2013
Merged

Remove unnecessary function call. #285

merged 1 commit into from
Jul 12, 2013

Conversation

cmeiklejohn
Copy link
Contributor

Remove function that is no longer required.

@rzezeski
Copy link
Contributor

Seems bit-rot got to this PR. Mind doing a rebase?

@cmeiklejohn
Copy link
Contributor Author

@rzezeski rebased.

@rzezeski
Copy link
Contributor

  • verify compile
  • verify eunit/EQC
  • grep all of riak, riak_control, riak_cs
  • verify with @jtuple that this isn't use in debugging or something

@cmeiklejohn
Copy link
Contributor Author

This was added by me in 7ae213f for Riak Control but became unnecessary.

@rzezeski
Copy link
Contributor

Oh nice, that saves me some time.

@cmeiklejohn
Copy link
Contributor Author

I've verified compile and eunit as well, but I'd definitely appreciate the double check.

@rzezeski
Copy link
Contributor

+1 to merge, ayo close that PR.

cmeiklejohn added a commit that referenced this pull request Jul 12, 2013
@cmeiklejohn
Merge pull request #285 from basho/csm-remove-unnecessary-fn
b258f7c 
Remove unnecessary function call.
@cmeiklejohn cmeiklejohn merged commit b258f7c into master Jul 12, 2013
@cmeiklejohn cmeiklejohn deleted the csm-remove-unnecessary-fn branch July 12, 2013 02:44
@cmeiklejohn
Copy link
Contributor Author

Thanks.

russelldb added a commit that referenced this pull request Sep 20, 2013
@russelldb
Add disk stats to /stats output to make consistent
224fdab 
As pointed out by @fygrave in #285, `riak-admin status` shows
diak stats, but `/stats` does not. This fixes that.#285, `riak-admin status` shows
diak stats, but `/stats` does not. This fixes that.#285, `riak-admin status` shows
diak stats, but `/stats` does not. This fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmeiklejohn @rzezeski