Fix/az/remove dead code because legacy gossip is false #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that riak_core_gossip_legacy.erl is gone (after cleanup, there are no references to this module remaining in the entire riak/deps tree).
For some reason, dialyzer fails to use exported behaviour_info/1 and goes on to emit warnings in riak_kv. But it works fine with callback specs expressly provided.
There are three modules in riak_kv implementing this behaviour:
riak_kv_{buckets,keys,index}_fsm. The wirst two are good, but the
"index" one has process_results/2 deprecated (L191 has this comment:
"Legacy, unsorted 2i, should remove?"), instead exporting process_result/3,
which is not a legislated callback of that behaviour.
A quick resolution to this, somewhat nitpicky, issue would be to just let
riak_kv_index_fsm not implement this behaviour. Hereby I'm soliciting
more informative suggestions -- or we could just let it be, along with a
corresponding entry in riak_kv/dialyzer.ignore-warnings, and wait for a
more sweeping change to flush this tiny piece of impropriety.
…d-code-because-legacy_gossip-is-false # Conflicts: # dialyzer.ignore-warnings
|
With the merge of 'fix/az/assorted-dialyzer-issues', dialyzer.ignored-warnings shrinks to 0. However, please look at c5a0a7b. |
|
Looks like this wheel has been invented already: #541. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to comment by @jonmeredith in basho/riak_kv#1104 "Also could do with a PR to clean up riak_core sometime", here's an attempt to carefully excise code that has become dead due to legacy_gossip and related functions being stubbed to 'false'.