Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary logging on anonymous access. #876

Closed
ksauzz opened this issue May 29, 2014 · 3 comments
Closed

Avoid unnecessary logging on anonymous access. #876

ksauzz opened this issue May 29, 2014 · 3 comments
Labels
Milestone

Comments

@ksauzz
Copy link
Contributor

ksauzz commented May 29, 2014

We shouldn't output no_user_key error on proper anonymous access such as getting a public object.

2014-05-29 18:08:35.835 [error] <0.2515.0>@riak_cs_wm_common:maybe_create_user:218 Retrieval of user record for s3 failed. Reason: no_user_key
@shino shino added the Bug label Jun 6, 2014
@shino shino added this to the 1.5.0 milestone Jun 6, 2014
@shino
Copy link
Contributor

shino commented Jun 6, 2014

For example, if one use riak_cs for file download with public read ACL, this log can happen heavily. Lager, by default setting, calls file:datasync/1 for error or higher severity [1]. So this issue may increase disk load.

[1] https://github.com/basho/lager/blob/master/src/lager_file_backend.erl#L228

@shino
Copy link
Contributor

shino commented Jun 6, 2014

Move to 1.5.0

@shino
Copy link
Contributor

shino commented Jun 12, 2014

Resolved by #883.

@shino shino closed this as completed Jun 12, 2014
kuenishi added a commit that referenced this issue Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants