Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ceph tests to the latest version. #1096

Merged
merged 6 commits into from
Mar 20, 2015
Merged

Conversation

ksauzz
Copy link
Contributor

@ksauzz ksauzz commented Mar 18, 2015

basho/s3-tests#2 is needed to pass the tests.

@kuenishi kuenishi added this to the 2.0.0 milestone Mar 19, 2015
@kuenishi
Copy link
Contributor

Addresses #1085 (RCS-134).

@kuenishi
Copy link
Contributor

Not a bug of this pull request, but I'd like this patched:

diff --git a/client_tests/python/boto_tests/boto_test.py b/client_tests/python/boto_tests/boto_test.py
index dbfa39c..bfbef4c 100755
--- a/client_tests/python/boto_tests/boto_test.py
+++ b/client_tests/python/boto_tests/boto_test.py
@@ -33,6 +33,8 @@ import boto

 def setup_auth_scheme():
     auth_mech=os.environ.get('CS_AUTH', 'auth-v2')
+    if not boto.config.has_section('s3'):
+        boto.config.add_section('s3')
     if auth_mech == 'auth-v4':
         setup_auth_v4()
     else:
@@ -41,13 +43,11 @@ def setup_auth_scheme():
 def setup_auth_v4():
     print('Use AWS Version 4 authentication')
     if not boto.config.get('s3', 'use-sigv4'):
-        boto.config.add_section('s3')
         boto.config.set('s3', 'use-sigv4', 'True')

This code conflicted with my ~/.boto s3 section.

@kuenishi
Copy link
Contributor

I'll do +1 if above patch merged. Good job.

@kuenishi
Copy link
Contributor

all r_t has passed

borshop added a commit that referenced this pull request Mar 20, 2015
Update ceph tests to the latest version.

Reviewed-by: kuenishi
@kuenishi
Copy link
Contributor

@borshop merge

@borshop borshop merged commit 700dff3 into develop Mar 20, 2015
@kuenishi kuenishi deleted the feature/update-ceph-tests branch March 20, 2015 07:33
@kuenishi
Copy link
Contributor

@ksauzz Pleas list up all issues found via your work here.

@ksauzz
Copy link
Contributor Author

ksauzz commented Mar 21, 2015

  1. Unnecessary NextMarker
  2. CS should respond 'Not Found' if bucket is not existed. (test)
  3. Support non-canned ACL. (test)
  4. CS should respond 'InvalidAccessKeyId' if non-existent key id is sent. (test)
  5. CS should responds 'SignatureDoesNotMatch' if a signature is not match. (test)
  6. Copy API should copy user meta data.
  7. CS should refuse a empty request on multipart completion.
  8. CS should respond NoSuchUpload. (test)

@kuenishi
Copy link
Contributor

Thanks (thumbup)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants