Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/missing conf in schema #1115

Merged
merged 7 commits into from
Apr 3, 2015
Merged

Bugfix/missing conf in schema #1115

merged 7 commits into from
Apr 3, 2015

Conversation

shino
Copy link
Contributor

@shino shino commented Apr 2, 2015

  • Add switch for access log output
  • Add two configs gc.batch_size and max_buckets_per_user those are missing at 2.0.0

Addresses #1109

@shino shino added the Bug label Apr 2, 2015
@shino shino added this to the 2.0.1 milestone Apr 2, 2015
kuenishi
kuenishi reviewed Apr 2, 2015
View reviewed changes
rel/files/riak_cs.schema
{mapping, "log.access", "webmachine.log_handlers", [
{default, on},
{datatype, flag}
]}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add unit test for this in default_config_test .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we do that? It seems that defualt_config_test asserts against application environment keys.

@kuenishi
Copy link
Contributor

kuenishi commented Apr 2, 2015

Basically the code looks nice, ... and good catch! I also want you to update configuration mapping table in the release notes. +known issues.

@shino
Copy link
Contributor Author

shino commented Apr 3, 2015

Will rebase and force push to include changes from #1114

@shino shino force-pushed the bugfix/missing-conf-in-schema branch from d7b2294 to c507dbe Compare April 3, 2015 02:21
@shino
Copy link
Contributor Author

shino commented Apr 3, 2015

Thanks for review. Updated, ready for review again.

@kuenishi
Copy link
Contributor

kuenishi commented Apr 3, 2015

Opened cuttlefish case: basho/cuttlefish#188

@kuenishi
Copy link
Contributor

kuenishi commented Apr 3, 2015

Oddness might be wrong word for this. Sorry!

@kuenishi kuenishi force-pushed the bugfix/missing-conf-in-schema branch from a7802ac to a2ba4fd Compare April 3, 2015 04:09
@shino
Copy link
Contributor Author

shino commented Apr 3, 2015

+1 for your commit 😄

@kuenishi
Copy link
Contributor

kuenishi commented Apr 3, 2015

running rt now

@kuenishi
Copy link
Contributor

kuenishi commented Apr 3, 2015

I think no degradation can happen with this PR, caremad.

@shino
Copy link
Contributor Author

shino commented Apr 3, 2015

I could not find the bug you found, it was because I skipped r_t (and generate before that) 🙉

borshop added a commit that referenced this pull request Apr 3, 2015
@borshop
Merge pull request #1115 from basho/bugfix/missing-conf-in-schema
4c92fad 
Bugfix/missing conf in schema

Reviewed-by: kuenishi
@kuenishi
Copy link
Contributor

kuenishi commented Apr 3, 2015

@borshop merge

@borshop borshop merged commit a2ba4fd into 2.0 Apr 3, 2015
@kuenishi kuenishi deleted the bugfix/missing-conf-in-schema branch April 3, 2015 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shino @kuenishi @borshop